[Linux-stm32] [bug report] drm/stm: support runtime power management
Dan Carpenter
dan.carpenter at linaro.org
Mon May 15 08:07:09 UTC 2023
Hello Yannick Fertré,
The patch 35ab6cfbf211: "drm/stm: support runtime power management"
from Jun 3, 2019, leads to the following Smatch static checker
warning:
drivers/gpu/drm/stm/ltdc.c:940 ltdc_crtc_mode_set_nofb()
warn: pm_runtime_get_sync() also returns 1 on success
drivers/gpu/drm/stm/ltdc.c
937
938 if (!pm_runtime_active(ddev->dev)) {
939 ret = pm_runtime_get_sync(ddev->dev);
--> 940 if (ret) {
Yep. Better to use pm_runtime_resume_and_get().
941 DRM_ERROR("Failed to set mode, cannot get sync\n");
942 return;
943 }
944 }
945
regards,
dan carpenter
More information about the Linux-stm32
mailing list