[Linux-stm32] [bug report] drm/stm: ltdc: add support for CRC hashing feature

Dan Carpenter dan.carpenter at linaro.org
Mon May 15 06:13:12 UTC 2023


Hello Raphael Gallais-Pou,

This is a semi-automatic email about new static checker warnings.

The patch 79b44684a14e: "drm/stm: ltdc: add support for CRC hashing 
feature" from Feb 11, 2022, leads to the following Smatch complaint:

    drivers/gpu/drm/stm/ltdc.c:1153 ltdc_crtc_set_crc_source()
    warn: variable dereferenced before check 'crtc' (see line 1148)

drivers/gpu/drm/stm/ltdc.c
  1147	{
  1148		struct ltdc_device *ldev = crtc_to_ltdc(crtc);
                                                        ^^^^
Dereferenced.

  1149		int ret;
  1150	
  1151		DRM_DEBUG_DRIVER("\n");
  1152	
  1153		if (!crtc)
                    ^^^^^
Checked too late.  Hopefully, this check can just be deleted.

  1154			return -ENODEV;
  1155	

regards,
dan carpenter



More information about the Linux-stm32 mailing list