[Linux-stm32] [RFC PATCH net-next] net: phylink: rename mac_link_state() op to mac_pcs_get_state()

Florian Fainelli f.fainelli at gmail.com
Thu Nov 21 03:52:25 UTC 2019



On 11/20/2019 6:17 PM, Andrew Lunn wrote:
>> This is something I'd like to do to make it clearer what phylink expects
>> of this function, and that it shouldn't just read-back how the MAC was
>> configured.  However, it will require some testing and review as it
>> changes quite a lot, and there's some things, particularly in DSA, that
>> don't seem quite right from a phylink point of view, such as messing
>> with state->interface in this function.
> 
> Hi Russell
> 
> Could you have more detail about DSA issues? Do you means the 6250
> setting interface to PHY_INTERFACE_MODE_NA?
> 
> I think you and i have pretty similar marvell hardware. So i don't
> think i can do much additional testing. Ideally we want Florian to do
> some testing on b53.

I will try to test that across the hardware I have at hand, can take a
few days to get all platforms working with net-next. At first glance,
this is just a simple rename and change of return type, I would not
expect problems to arise from that.
-- 
Florian



More information about the Linux-stm32 mailing list