[Linux-stm32] [RFC PATCH net-next] net: phylink: rename mac_link_state() op to mac_pcs_get_state()

Andrew Lunn andrew at lunn.ch
Thu Nov 21 02:17:40 UTC 2019


> This is something I'd like to do to make it clearer what phylink expects
> of this function, and that it shouldn't just read-back how the MAC was
> configured.  However, it will require some testing and review as it
> changes quite a lot, and there's some things, particularly in DSA, that
> don't seem quite right from a phylink point of view, such as messing
> with state->interface in this function.

Hi Russell

Could you have more detail about DSA issues? Do you means the 6250
setting interface to PHY_INTERFACE_MODE_NA?

I think you and i have pretty similar marvell hardware. So i don't
think i can do much additional testing. Ideally we want Florian to do
some testing on b53.

Andrew



More information about the Linux-stm32 mailing list