[Linux-stm32] [PATCH v2] ASoC: stm32: spdifrx: keep the control DMA channel on config failure

Krzysztof Kozlowski krzk at kernel.org
Fri Nov 6 08:07:30 CET 2026


On 06/11/2026 04:54, Wentao Liang wrote:
> When dmaengine_slave_config() fails, stm32_spdifrx_dma_ctrl_register()
> sets ctrl_chan to NULL and returns the error. The channel obtained from
> dma_request_chan() is thus lost, and stm32_spdifrx_probe() calls
> stm32_spdifrx_remove() on the error path, which then passes NULL to
> dma_release_channel().
> 
> Leave ctrl_chan untouched so that the remove path releases the channel.
> Its IS_ERR() check already handles the case where dma_request_chan()
> failed.
> 
> Fixes: 98c8dc2fd59f ("ASoC: stm32: spdifrx: fix control DMA error management")
> Cc: stable at vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex

You still do not bother to run checkpatch, even though I pointed this
many times.

You truly cannot show more how much you ignore people's comments. The
reply to me with "apologize" was a joke, right?

Best regards,
Krzysztof


More information about the Linux-stm32 mailing list