[Linux-stm32] [PATCH net-next 1/2] dt-bindings: net: Add Siflower SF19A2890 GMAC

[Andrew Lunn]

> +  rx-internal-delay-ps:
> +    description:
> +      Applied in steps of about 55 ps, rounded to the nearest step.
> +    maximum: 14025

Please add minimum, and multipleOf.

I've not looked at the code yet, but default: 0 would also be good.

> +        rx-internal-delay-ps = <550>;
> +        tx-internal-delay-ps = <935>;

These values are odd. The RGMII standard says 2ns is required. Where
is the rest coming from.

> +        fixed-link {
> +            speed = <1000>;
> +            full-duplex;
> +        };

Does this mean there is a switch on the other end? Maybe look at what
the switch is doing for RGMII delays.

	Andrew