[Linux-stm32] [PATCH] net: dwmac-rk: No need to check the return value of the phy_power_on()

Andrew Lunn andrew at lunn.ch
Tue May 27 13:14:56 UTC 2025


On Tue, May 27, 2025 at 07:43:57AM +0200, Christophe JAILLET wrote:
> Le 26/05/2025 à 18:16, 李哲 a écrit :
> > since the return value of the phy_power_on() function is always 0,
> > checking its return value is redundant.
> 
> Can you elaborate why?
> 
> Looking at  (1], I think that it is obvious that non-0 values can be
> returned.

Wrong phy_power_on(). There is a local scope one within the driver.

	Andrew



More information about the Linux-stm32 mailing list