[Linux-stm32] [PATCH v2 2/2] dt-bindings: net: add new property st, ext-phyclk in documentation for stm32

[Christophe ROULLIER]

On 3/8/24 09:28, Krzysztof Kozlowski wrote:
> On 07/03/2024 14:59, Christophe Roullier wrote:
>> Add property st,ext-phyclk to manage cases when PHY have no cristal/quartz
>> This property can be used with RMII phy without cristal 50Mhz and when we
>> want to select RCC clock instead of ETH_REF_CLK
>> Can be used also with RGMII phy with no cristal and we select RCC clock
>> instead of ETH_CLK125
>>
> Nothing improved here. You say you add new property (wrote it explicitly
> in the subject), but where is it? Where is the user?
>
> I think we talked about this. Rob also asked quite clear:
>
>> That is obvious from the diff. What is not obvious is why we need a new
>> property and what is the problem with the existing ones.
> How did you solve it?

Hi,

I do not understand your questions.

That I would like to do, it is property "st,ext-phyclk" was introduced 
in driver

"drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c" in 2020, and YAML 
was not updated at the time.

Goal of this patch it is to update YAML to avoid dtbs check issue if 
someone use this property :

  dtbs check issue : views/kernel/upstream/net-next/arch/arm/boot/dts/st/stm32mp157c-dk2.dtb:
ethernet at 5800a000: Unevaluated properties are not allowed
('st,ext-phyclk' was unexpected)

Regards,

Christophe

>
> Best regards,
> Krzysztof
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://st-md-mailman.stormreply.com/pipermail/linux-stm32/attachments/20240313/a7ac920b/attachment.html>