[Linux-stm32] [PATCH v5 08/12] net: stmmac: dwmac-stm32: add management of stm32mp13 for stm32

[Christophe ROULLIER]

On 6/7/24 14:48, Marek Vasut wrote:
> On 6/7/24 11:57 AM, Christophe Roullier wrote:
>
> [...]
>
>> @@ -224,11 +225,18 @@ static int stm32mp1_configure_pmcr(struct 
>> plat_stmmacenet_data *plat_dat)
>>   {
>>       struct stm32_dwmac *dwmac = plat_dat->bsp_priv;
>>       u32 reg = dwmac->mode_reg;
>> -    int val;
>> +    int val = 0;
>
> Is the initialization really needed ? It seems the switch-case below 
> does always initialize $val .

Yes it is needed otherwise:

>> drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c:239:4: warning: variable 'val' is uninitialized when used here [-Wuninitialized]

val |= SYSCFG_PMCR_ETH_SEL_MII;
                            ^~~
    drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c:228:9: note: initialize the variable 'val' to silence this warning
            int val;

>
>>       switch (plat_dat->mac_interface) {
>>       case PHY_INTERFACE_MODE_MII:
>> -        val = SYSCFG_PMCR_ETH_SEL_MII;
>> +        /*
>> +         * STM32MP15xx supports both MII and GMII, STM32MP13xx MII 
>> only.
>> +         * SYSCFG_PMCSETR ETH_SELMII is present only on STM32MP15xx and
>> +         * acts as a selector between 0:GMII and 1:MII. As STM32MP13xx
>> +         * supports only MII, ETH_SELMII is not present.
>> +         */
>> +        if (!dwmac->ops->is_mp13)  /* Select MII mode on STM32MP15xx */
>> +            val |= SYSCFG_PMCR_ETH_SEL_MII;
>>           break;
>>       case PHY_INTERFACE_MODE_GMII:
>>           val = SYSCFG_PMCR_ETH_SEL_GMII;
>
> [...]
>
> This way of adding MP13 support definitely looks much better.
>
> Also, split the series, drivers/ stuff for netdev (and make sure to 
> include the net-next patch prefix , git send-email 
> --subject-prefix="net-next,PATCH") , DTs for linux-arm-kernel , config 
> patch also for linux-arm-kernel .
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://st-md-mailman.stormreply.com/pipermail/linux-stm32/attachments/20240607/7e5ee974/attachment.html>