[Linux-stm32] [PATCH] net: stmmac: fix out-of-bounds read via memcpy detected by KASAN
Ray Zhang
sgzhang at google.com
Tue Nov 21 20:06:47 UTC 2023
Hi Andrew,
Thanks for reviewing, please see inline.
On Tue, Nov 21, 2023 at 11:46 AM Andrew Lunn <andrew at lunn.ch> wrote:
> On Tue, Nov 21, 2023 at 06:45:43PM +0000, Ray Zhang wrote:
> > CONFIG_KASAN detected out-of-bounds read via memcpy in
> stmmac_get_strings.
> > The fix is to change memcpy to strscpy.
> >
> > Tested:
> > <machine_obfuscated>:~# ethtool -i <interface_obfuscated>
> > driver: st_gmac
> > <machine_obfuscated>:~# ethtool -S <interface_obfuscated>
> > NIC statistics:
> > ATPES: 0
> > TPES: 0
> > RDPES: 0
> > MPES: 0
> > MTSPES: 0
> > ARPES: 0
> > CWPES: 0
> > ASRPES: 0
> > TTES: 0
> > RTES: 0
> > CTES: 0
> > ATES: 0
> > PTES: 0
> > T125ES: 0
> > R125ES: 0
> > RVCTES: 0
> > MSTTES: 0
> > SLVTES: 0
> > ATITES: 0
> > ARITES: 0
> > FSMPES: 0
> > TXCES: 0
> > TXAMS: 0
> > TXUES: 0
> > RXCES: 0
> > RXAMS: 0
> > RXUES: 0
> > ECES: 0
> > EAMS: 0
> > EUES: 0
> > RPCES: 0
> > RPAMS: 0
> > RPUES: 0
> > TCES: 0
> > TAMS: 0
> > TUES: 0
> > mmc_tx_octetcount_gb: 11612
> > mmc_tx_framecount_gb: 100
> > mmc_tx_broadcastframe_g: 0
> > mmc_tx_multicastframe_g: 42
> > mmc_tx_64_octets_gb: 0
> > mmc_tx_65_to_127_octets_gb: 62
> > mmc_tx_128_to_255_octets_gb: 38
> > mmc_tx_256_to_511_octets_gb: 0
> > mmc_tx_512_to_1023_octets_gb: 0
> > mmc_tx_1024_to_max_octets_gb: 0
> > mmc_tx_unicast_gb: 58
> > mmc_tx_multicast_gb: 42
> > mmc_tx_broadcast_gb: 0
> > mmc_tx_underflow_error: 0
> > mmc_tx_singlecol_g: 0
> > mmc_tx_multicol_g: 0
> > mmc_tx_deferred: 0
> > mmc_tx_latecol: 0
> > mmc_tx_exesscol: 0
> > mmc_tx_carrier_error: 0
> > mmc_tx_octetcount_g: 11612
> > mmc_tx_framecount_g: 100
> > mmc_tx_excessdef: 0
> > mmc_tx_pause_frame: 0
> > mmc_tx_vlan_frame_g: 0
> > mmc_rx_framecount_gb: 64
> > mmc_rx_octetcount_gb: 30235
> > mmc_rx_octetcount_g: 30235
> > mmc_rx_broadcastframe_g: 0
> > mmc_rx_multicastframe_g: 0
> > mmc_rx_crc_error: 0
> > mmc_rx_align_error: 0
> > mmc_rx_run_error: 0
> > mmc_rx_jabber_error: 0
> > mmc_rx_undersize_g: 0
> > mmc_rx_oversize_g: 0
> > mmc_rx_64_octets_gb: 0
> > mmc_rx_65_to_127_octets_gb: 9
> > mmc_rx_128_to_255_octets_gb: 22
> > mmc_rx_256_to_511_octets_gb: 21
> > mmc_rx_512_to_1023_octets_gb: 2
> > mmc_rx_1024_to_max_octets_gb: 10
> > mmc_rx_unicast_g: 64
> > mmc_rx_length_error: 0
> > mmc_rx_autofrangetype: 0
> > mmc_rx_pause_frames: 0
> > mmc_rx_fifo_overflow: 0
> > mmc_rx_vlan_frames_gb: 0
> > mmc_rx_watchdog_error: 0
> > mmc_rx_ipc_intr_mask: 0
> > mmc_rx_ipc_intr: 0
> > mmc_rx_ipv4_gd: 0
> > mmc_rx_ipv4_hderr: 0
> > mmc_rx_ipv4_nopay: 0
> > mmc_rx_ipv4_frag: 0
> > mmc_rx_ipv4_udsbl: 0
> > mmc_rx_ipv4_gd_octets: 0
> > mmc_rx_ipv4_hderr_octets: 0
> > mmc_rx_ipv4_nopay_octets: 0
> > mmc_rx_ipv4_frag_octets: 0
> > mmc_rx_ipv4_udsbl_octets: 0
> > mmc_rx_ipv6_gd_octets: 0
> > mmc_rx_ipv6_hderr_octets: 0
> > mmc_rx_ipv6_nopay_octets: 0
> > mmc_rx_ipv6_gd: 0
> > mmc_rx_ipv6_hderr: 0
> > mmc_rx_ipv6_nopay: 0
> > mmc_rx_udp_gd: 0
> > mmc_rx_udp_err: 0
> > mmc_rx_tcp_gd: 0
> > mmc_rx_tcp_err: 0
> > mmc_rx_icmp_gd: 0
> > mmc_rx_icmp_err: 0
> > mmc_rx_udp_gd_octets: 0
> > mmc_rx_udp_err_octets: 0
> > mmc_rx_tcp_gd_octets: 0
> > mmc_rx_tcp_err_octets: 0
> > mmc_rx_icmp_gd_octets: 0
> > mmc_rx_icmp_err_octets: 0
> > mmc_tx_fpe_fragment_cntr: 0
> > mmc_tx_hold_req_cntr: 0
> > mmc_rx_packet_assembly_err_cntr: 0
> > mmc_rx_packet_smd_err_cntr: 0
> > mmc_rx_packet_assembly_ok_cntr: 0
> > mmc_rx_fpe_fragment_cntr: 0
> > tx_underflow: 0
> > tx_carrier: 0
> > tx_losscarrier: 0
> > vlan_tag: 0
> > tx_deferred: 0
> > tx_vlan: 0
> > tx_jabber: 0
> > tx_frame_flushed: 0
> > tx_payload_error: 0
> > tx_ip_header_error: 0
> > rx_desc: 0
> > sa_filter_fail: 0
> > overflow_error: 0
> > ipc_csum_error: 0
> > rx_collision: 0
> > rx_crc_errors: 0
> > dribbling_bit: 0
> > rx_length: 0
> > rx_mii: 0
> > rx_multicast: 0
> > rx_gmac_overflow: 0
> > rx_watchdog: 0
> > da_rx_filter_fail: 0
> > sa_rx_filter_fail: 0
> > rx_missed_cntr: 0
> > rx_overflow_cntr: 0
> > rx_vlan: 0
> > rx_split_hdr_pkt_n: 0
> > tx_undeflow_irq: 0
> > tx_process_stopped_irq: 0
> > tx_jabber_irq: 0
> > rx_overflow_irq: 0
> > rx_buf_unav_irq: 0
> > rx_process_stopped_irq: 0
> > rx_watchdog_irq: 0
> > tx_early_irq: 0
> > fatal_bus_error_irq: 0
> > rx_early_irq: 0
> > threshold: 64
> > tx_pkt_n: 100
> > rx_pkt_n: 64
> > normal_irq_n: 62
> > rx_normal_irq_n: 58
> > napi_poll: 215
> > tx_normal_irq_n: 4
> > tx_clean: 157
> > tx_set_ic_bit: 4
> > irq_receive_pmt_irq_n: 0
> > mmc_tx_irq_n: 0
> > mmc_rx_irq_n: 0
> > mmc_rx_csum_offload_irq_n: 0
> > irq_tx_path_in_lpi_mode_n: 0
> > irq_tx_path_exit_lpi_mode_n: 0
> > irq_rx_path_in_lpi_mode_n: 0
> > irq_rx_path_exit_lpi_mode_n: 0
> > phy_eee_wakeup_error_n: 0
> > ip_hdr_err: 0
> > ip_payload_err: 0
> > ip_csum_bypassed: 0
> > ipv4_pkt_rcvd: 0
> > ipv6_pkt_rcvd: 64
> > no_ptp_rx_msg_type_ext: 64
> > ptp_rx_msg_type_sync: 0
> > ptp_rx_msg_type_follow_up: 0
> > ptp_rx_msg_type_delay_req: 0
> > ptp_rx_msg_type_delay_resp: 0
> > ptp_rx_msg_type_pdelay_req: 0
> > ptp_rx_msg_type_pdelay_resp: 0
> > ptp_rx_msg_type_pdelay_follow_up: 0
> > ptp_rx_msg_type_announce: 0
> > ptp_rx_msg_type_management: 0
> > ptp_rx_msg_pkt_reserved_type: 0
> > ptp_frame_type: 0
> > ptp_ver: 0
> > timestamp_dropped: 0
> > av_pkt_rcvd: 0
> > av_tagged_pkt_rcvd: 0
> > vlan_tag_priority_val: 0
> > l3_filter_match: 0
> > l4_filter_match: 0
> > l3_l4_filter_no_match: 0
> > irq_pcs_ane_n: 0
> > irq_pcs_link_n: 0
> > irq_rgmii_n: 0
> > mtl_tx_status_fifo_full: 0
> > mtl_tx_fifo_not_empty: 0
> > mmtl_fifo_ctrl: 0
> > mtl_tx_fifo_read_ctrl_write: 0
> > mtl_tx_fifo_read_ctrl_wait: 0
> > mtl_tx_fifo_read_ctrl_read: 0
> > mtl_tx_fifo_read_ctrl_idle: 0
> > mac_tx_in_pause: 0
> > mac_tx_frame_ctrl_xfer: 0
> > mac_tx_frame_ctrl_idle: 0
> > mac_tx_frame_ctrl_wait: 0
> > mac_tx_frame_ctrl_pause: 0
> > mac_gmii_tx_proto_engine: 0
> > mtl_rx_fifo_fill_level_full: 0
> > mtl_rx_fifo_fill_above_thresh: 0
> > mtl_rx_fifo_fill_below_thresh: 0
> > mtl_rx_fifo_fill_level_empty: 0
> > mtl_rx_fifo_read_ctrl_flush: 0
> > mtl_rx_fifo_read_ctrl_read_data: 0
> > mtl_rx_fifo_read_ctrl_status: 0
> > mtl_rx_fifo_read_ctrl_idle: 0
> > mtl_rx_fifo_ctrl_active: 0
> > mac_rx_frame_ctrl_fifo: 0
> > mac_gmii_rx_proto_engine: 0
> > tx_tso_frames: 0
> > tx_tso_nfrags: 0
> > mtl_est_cgce: 0
> > mtl_est_hlbs: 0
> > mtl_est_hlbf: 0
> > mtl_est_btre: 0
> > mtl_est_btrlm: 0
> > q0_tx_pkt_n: 100
> > q0_tx_irq_n: 4
> > q0_rx_pkt_n: 64
> > q0_rx_irq_n: 58
>
> What useful information does this list of statistics bring in the
> commit message?
>
Each output line of "ethtool -S" is from the modified code: It shows the
command still yields normal output results as expected.
>
> > if (!stmmac_safety_feat_dump(priv,
> > &priv->sstats, i,
> > NULL, &desc)) {
> > - memcpy(p, desc, ETH_GSTRING_LEN);
> > + strscpy(p, desc, ETH_GSTRING_LEN);
>
> Did you consider ethtool_puts() ?
>
No, since strscpy does the job already. Also I could not find ethtool_puts:
where is it defined? Or do you mean ethtool_put_stat, which is
inappropriate to use here since it requires a skb parameter?
> Andrew
>
> ---
> pw-bot: cr
>
Ray
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://st-md-mailman.stormreply.com/pipermail/linux-stm32/attachments/20231121/9f1376f0/attachment.html>
More information about the Linux-stm32
mailing list