[Linux-stm32] [PATCH v3 05/10] mmc: mmci: Make busy complete state machine explicit
Ulf Hansson
ulf.hansson at linaro.org
Tue Jun 13 12:08:06 UTC 2023
[...]
> @@ -1259,6 +1276,8 @@ mmci_start_command(struct mmci_host *host, struct mmc_command *cmd, u32 c)
>
> host->busy_status = 0;
> if ((cmd->flags & MMC_RSP_BUSY) && (host->variant->busy_timeout)) {
> + host->busy_state = MMCI_BUSY_DONE;
> +
Nitpick:
I would move this up a few lines, along when clearing the busy_status.
In other words, let's clear the busy_state no matter if the current
command flag has MMC_RSP_BUSY.
> if (!cmd->busy_timeout)
> cmd->busy_timeout = 10 * MSEC_PER_SEC;
>
[...]
Kind regards
Uffe
More information about the Linux-stm32
mailing list