[Linux-stm32] [PATCH 2/2] pwm: stmpe: Don't issue error messages for problems in .apply_state()

[Uwe Kleine-König]

pwm drivers are supposed to be silent for failures in .apply_state()
because a problem is likely to be persistent and so it can easily flood
the kernel log. So remove all error messages from .apply_state() and the
functions that are (only) called by that callback.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
---
 drivers/pwm/pwm-stmpe.c | 35 ++++++-----------------------------
 1 file changed, 6 insertions(+), 29 deletions(-)

diff --git a/drivers/pwm/pwm-stmpe.c b/drivers/pwm/pwm-stmpe.c
index e205405c4828..4a8d0d9b9cfc 100644
--- a/drivers/pwm/pwm-stmpe.c
+++ b/drivers/pwm/pwm-stmpe.c
@@ -43,22 +43,12 @@ static int stmpe_24xx_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
 	int ret;
 
 	ret = stmpe_reg_read(stmpe_pwm->stmpe, STMPE24XX_PWMCS);
-	if (ret < 0) {
-		dev_err(chip->dev, "error reading PWM#%u control\n",
-			pwm->hwpwm);
+	if (ret < 0)
 		return ret;
-	}
 
 	value = ret | BIT(pwm->hwpwm);
 
-	ret = stmpe_reg_write(stmpe_pwm->stmpe, STMPE24XX_PWMCS, value);
-	if (ret) {
-		dev_err(chip->dev, "error writing PWM#%u control\n",
-			pwm->hwpwm);
-		return ret;
-	}
-
-	return 0;
+	return stmpe_reg_write(stmpe_pwm->stmpe, STMPE24XX_PWMCS, value);
 }
 
 static int stmpe_24xx_pwm_disable(struct pwm_chip *chip,
@@ -69,19 +59,12 @@ static int stmpe_24xx_pwm_disable(struct pwm_chip *chip,
 	int ret;
 
 	ret = stmpe_reg_read(stmpe_pwm->stmpe, STMPE24XX_PWMCS);
-	if (ret < 0) {
-		dev_err(chip->dev, "error reading PWM#%u control\n",
-			pwm->hwpwm);
+	if (ret < 0)
 		return ret;
-	}
 
 	value = ret & ~BIT(pwm->hwpwm);
 
-	ret = stmpe_reg_write(stmpe_pwm->stmpe, STMPE24XX_PWMCS, value);
-	if (ret)
-		dev_err(chip->dev, "error writing PWM#%u control\n",
-			pwm->hwpwm);
-	return ret;
+	return stmpe_reg_write(stmpe_pwm->stmpe, STMPE24XX_PWMCS, value);
 }
 
 /* STMPE 24xx PWM instructions */
@@ -124,11 +107,8 @@ static int stmpe_24xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
 
 		ret = stmpe_set_altfunc(stmpe_pwm->stmpe, BIT(pin),
 					STMPE_BLOCK_PWM);
-		if (ret) {
-			dev_err(chip->dev, "unable to connect PWM#%u to pin\n",
-				pwm->hwpwm);
+		if (ret)
 			return ret;
-		}
 	}
 
 	/* STMPE24XX */
@@ -241,11 +221,8 @@ static int stmpe_24xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
 		value = program[i] & 0xff;
 
 		ret = stmpe_reg_write(stmpe_pwm->stmpe, offset, value);
-		if (ret) {
-			dev_err(chip->dev, "error writing register %02x: %d\n",
-				offset, ret);
+		if (ret)
 			return ret;
-		}
 	}
 
 	/* If we were enabled, re-enable this PWM */
-- 
2.39.2