[Linux-stm32] [EXT] Re: [PATCH v5 1/2] net: phylink: add mac_managed_pm in phylink_config structure

Jakub Kicinski kuba at kernel.org
Thu Oct 13 23:12:29 UTC 2022


On Thu, 13 Oct 2022 19:28:45 +0000 Shenwei Wang wrote:
> > Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
> > mdio_bus_phy_resume() state"
> >   
> 
> That was my original format. But it met the following warning when ran checkpatch.pl script:
> 
> ./scripts/checkpatch.pl 0001-net-phylink-add-mac_managed_pm-in-phylink_config-str.patch 
> WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: e6a39ffcfe22 ("net: stmmac: Enable mac_managed_pm phylink config")'
> #20: 
> Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
> 
> That's why I changed to the current tag format.

It needs to be all on one line:

Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")

But I don't see 47ac7b2f6a1f in my trees, are you sure that's 
the upstream commit id?



More information about the Linux-stm32 mailing list