[Linux-stm32] [PATCH net v4] net: stmmac: Set MAC's flow control register to reflect current settings

[Goh, Wei Sheng]

Hi there,

I would like to apologize for this.
Due to some mistake, I had resubmitted v4 at the same day before you review it.
I am working on v5 based on your review.
Very sorry for the confusion and appreciate your review.

Thanks & Best Regards,
Wei Sheng
________________________________
From: Lobakin, Alexandr <alexandr.lobakin at intel.com>
Sent: Saturday, November 26, 2022 00:02
To: Goh, Wei Sheng <wei.sheng.goh at intel.com>
Cc: Lobakin, Alexandr <alexandr.lobakin at intel.com>; Giuseppe Cavallaro <peppe.cavallaro at st.com>; Alexandre Torgue <alexandre.torgue at st.com>; Jose Abreu <joabreu at synopsys.com>; David S . Miller <davem at davemloft.net>; Eric Dumazet <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; Maxime Coquelin <mcoquelin.stm32 at gmail.com>; netdev at vger.kernel.org <netdev at vger.kernel.org>; linux-stm32 at st-md-mailman.stormreply.com <linux-stm32 at st-md-mailman.stormreply.com>; linux-arm-kernel at lists.infradead.org <linux-arm-kernel at lists.infradead.org>; linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org>; Alexandre Torgue <alexandre.torgue at foss.st.com>; Ong, Boon Leong <boon.leong.ong at intel.com>; Voon, Weifeng <weifeng.voon at intel.com>; Tan, Tee Min <tee.min.tan at intel.com>; Ahmad Tarmizi, Noor Azura <noor.azura.ahmad.tarmizi at intel.com>; Looi, Hong Aun <hong.aun.looi at intel.com>
Subject: Re: [PATCH net v4] net: stmmac: Set MAC's flow control register to reflect current settings

From: "Goh, Wei Sheng" <wei.sheng.goh at intel.com>
Date: Wed, 23 Nov 2022 18:51:10 +0800

> Currently, pause frame register GMAC_RX_FLOW_CTRL_RFE is not updated
> correctly when 'ethtool -A <IFACE> autoneg off rx off tx off' command
> is issued. This fix ensures the flow control change is reflected directly
> in the GMAC_RX_FLOW_CTRL_RFE register.

Any particular reason why you completely ignored by review comments
to the v3[0]? I'd like to see them fixed or at least replied.

>
> Fixes: 46f69ded988d ("net: stmmac: Use resolved link config in mac_link_up()")
> Cc: <stable at vger.kernel.org> # 5.10.x
> Signed-off-by: Goh, Wei Sheng <wei.sheng.goh at intel.com>
> Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi at intel.com>
> ---
> V3 -> V4: Fix commit message and incorrect insertions(+) value
> V2 -> V3: Removed value assign for 'flow' in else statement based on review comments
> V1 -> V2: Removed needless condition based on review comments
>
>  drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c |  2 ++
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12 ++++++++++--
>  2 files changed, 12 insertions(+), 2 deletions(-)

[...]

> --
> 2.17.1

[0] https://lore.kernel.org/netdev/20221123180947.488302-1-alexandr.lobakin@intel.com

Thanks,
Olek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://st-md-mailman.stormreply.com/pipermail/linux-stm32/attachments/20221125/21bf9ba7/attachment.html>