[Linux-stm32] [PATCH v5 0/9] media: v4l2-subdev: add subdev-wide state struct
Sakari Ailus
sakari.ailus at linux.intel.com
Fri Jun 11 06:14:13 UTC 2021
Moi,
On Thu, Jun 10, 2021 at 05:55:57PM +0300, Tomi Valkeinen wrote:
> Hi,
>
> v5 of the series. No content changes compared to v4, but the series is
> split into smaller parts to enable reviews.
>
> The split is artificial, and all the patches need to be squashed into
> one before merging.
>
> The point of the series is explained in "media: v4l2-subdev: add
> subdev-wide state struct", but for easier reviews I add it partially
> here:
>
> We have 'struct v4l2_subdev_pad_config' which contains configuration for
> a single pad used for the TRY functionality, and an array of those
> structs is passed to various v4l2_subdev_pad_ops.
>
> I was working on subdev internal routing between pads, and realized that
> there's no way to add TRY functionality for routes, which is not pad
> specific configuration. Adding a separate struct for try-route config
> wouldn't work either, as e.g. set-fmt needs to know the try-route
> configuration to propagate the settings.
>
> This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
> moment only contains the v4l2_subdev_pad_config array) and the new
> struct is used in most of the places where v4l2_subdev_pad_config was
> used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
> are changed to instead take v4l2_subdev_state.
Thanks for the update.
For the set:
Acked-by: Sakari Ailus <sakari.ailus at linux.intel.com>
--
Terveisin,
Sakari Ailus
More information about the Linux-stm32
mailing list