[Linux-stm32] [EXT] Re: [PATCH net 1/2] net: ethernet: dwmac: add Ethernet glue logic for NXP imx8 chip

[Andy Duan]

From: David Miller <davem at davemloft.net> Sent: Tuesday, May 26, 2020 9:13 AM
> From: Fugang Duan <fugang.duan at nxp.com>
> Date: Mon, 25 May 2020 18:29:13 +0800
> 
> > +static int imx_dwmac_init(struct platform_device *pdev, void *priv) {
> > +     struct imx_priv_data *dwmac = priv;
> > +     struct plat_stmmacenet_data *plat_dat = dwmac->plat_dat;
> > +     int ret;
> > +
> 
> Please code these sequences as:
> 
>         struct plat_stmmacenet_data *plat_dat;
>         struct imx_priv_data *dwmac = priv;
>         int ret;
> 
>         plat_dat = dwmac->plat_dat;
> 
> In order to have reverse christmas three local variable ordering.
> 
> THank you.

Thanks, David.
I will update the change in v2.

Andy