[Linux-stm32] [PATCH 07/13] dt-bindings: media: ov5640: Remove clock-lanes
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Fri Jul 17 20:48:29 UTC 2020
Hi Jacopo,
Thank you for the patch.
On Fri, Jul 17, 2020 at 03:28:53PM +0200, Jacopo Mondi wrote:
> The ov5640 does not support routing the clock signal to a different
> lane, and the property has value fixed to 0.
>
> Remove the property from the bindings and update its users
> accordingly.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas at jmondi.org>
When we'll convert video-interface.txt to YAML, let's state clearly that
properties should not be specified when the hardware is configurable.
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ov5640.yaml | 6 ------
> arch/arm/boot/dts/dra72-evm-common.dtsi | 1 -
> arch/arm/boot/dts/dra76-evm.dts | 1 -
> arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi | 1 -
> arch/arm/boot/dts/imx6qdl-icore.dtsi | 1 -
> arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 1 -
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 -
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 1 -
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 -
> 9 files changed, 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> index 8fd54575a1db..5e1662e848bd 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> @@ -76,9 +76,6 @@ properties:
> bus-type:
> enum: [4, 5]
>
> - clock-lanes:
> - const: 0
> -
> data-lanes:
> description: |
> Should be set to <1> or <1 2> (one or two CSI-2 lanes supported).
> @@ -125,7 +122,6 @@ properties:
> required:
> - remote-endpoint
> - bus-type
> - - clock-lanes
> - data-lanes
>
> - if:
> @@ -134,7 +130,6 @@ properties:
> const: 5
> then:
> properties:
> - clock-lanes: false
> data-lanes: false
> required:
> - remote-endpoint
> @@ -182,7 +177,6 @@ examples:
> ov5640_to_mipi_csi2: endpoint {
> remote-endpoint = <&mipi_csi2_from_ov5640>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
> index aba7eb55525d..b5b31dc927d4 100644
> --- a/arch/arm/boot/dts/dra72-evm-common.dtsi
> +++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
> @@ -288,7 +288,6 @@ port {
> csi2_cam0: endpoint {
> remote-endpoint = <&csi2_phy0>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/dra76-evm.dts b/arch/arm/boot/dts/dra76-evm.dts
> index ddf16e65ec7f..6fcb96abc41d 100644
> --- a/arch/arm/boot/dts/dra76-evm.dts
> +++ b/arch/arm/boot/dts/dra76-evm.dts
> @@ -421,7 +421,6 @@ port {
> csi2_cam0: endpoint {
> remote-endpoint = <&csi2_phy0>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> index dd5765778e87..a12d80a2403e 100644
> --- a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> +++ b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> @@ -275,7 +275,6 @@ port {
> ov5640_to_mipi_csi2: endpoint {
> remote-endpoint = <&mipi_csi2_in>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> index 2b1f275b8cc4..05bd332f527b 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> @@ -214,7 +214,6 @@ port {
> ov5640_to_mipi_csi2: endpoint {
> remote-endpoint = <&mipi_csi2_in>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> index 5752abb48e68..5eb7fbf33069 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> @@ -383,7 +383,6 @@ port {
> ov5640_to_mipi_csi2: endpoint {
> remote-endpoint = <&mipi_csi2_in>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 990f4cc345da..02f78b46a8fd 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -314,7 +314,6 @@ port {
> ov5640_to_mipi_csi2: endpoint {
> remote-endpoint = <&mipi_csi2_in>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> index 5c79ad5e7b5d..8c24fd468a22 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> @@ -628,7 +628,6 @@ camera_rear at 3b {
> port {
> ov5640_ep: endpoint {
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> remote-endpoint = <&csiphy0_ep>;
> };
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index 33f4eceffbe5..dd6a636ba3af 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -255,7 +255,6 @@ port {
> csi2_cam0: endpoint {
> remote-endpoint = <&csi2_phy0>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
--
Regards,
Laurent Pinchart
More information about the Linux-stm32
mailing list