[Linux-stm32] [PATCH] ubi: Fix an error pointer dereference in error handling code
Dan Carpenter
dan.carpenter at oracle.com
Fri Jan 17 03:40:35 UTC 2020
On Fri, Jan 17, 2020 at 12:50:14AM +0100, Richard Weinberger wrote:
> On Mon, Jan 13, 2020 at 2:24 PM Dan Carpenter <dan.carpenter at oracle.com> wrote:
> >
> > If "seen_pebs = init_seen(ubi);" fails then "seen_pebs" is an error pointer
> > and we try to kfree() it which results in an Oops.
> >
> > This patch re-arranges the error handling so now it only frees things
> > which have been allocated successfully.
> >
> > Fixes: daef3dd1f0ae ("UBI: Fastmap: Add self check to detect absent PEBs")
> > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> > ---
> > drivers/mtd/ubi/fastmap.c | 19 +++++++++++--------
> > 1 file changed, 11 insertions(+), 8 deletions(-)
> > ---
> > drivers/mtd/ubi/fastmap.c | 21 ++++++++++++---------
> > 1 file changed, 12 insertions(+), 9 deletions(-)
>
> This patch seems badly formatted.
> Copy&paste error?
>
Oh, yeah. Sorrry. I shouldn't affect anything though. I can resend
if you want.
regards,
dan carpenter
More information about the Linux-stm32
mailing list