[Linux-stm32] [PATCH net] device property: change device_get_phy_mode() to prevent signedess bugs
kbuild test robot
lkp at intel.com
Mon Feb 3 00:16:32 UTC 2020
Hi Dan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
[also build test ERROR on driver-core/driver-core-testing linus/master v5.5 next-20200131]
[cannot apply to sparc-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Dan-Carpenter/device-property-change-device_get_phy_mode-to-prevent-signedess-bugs/20200203-043126
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git b7c3a17c6062701d97a0959890a2c882bfaac537
config: x86_64-randconfig-s0-20200203 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>
All errors (new ones prefixed by >>):
>> drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c:110:12: error: conflicting types for 'phy_write'
static int phy_write(struct phy *phy, u32 value, unsigned int reg)
^~~~~~~~~
In file included from include/linux/property.h:15:0,
from include/linux/of.h:22,
from include/linux/clk-provider.h:9,
from drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c:8:
include/linux/phy.h:730:19: note: previous definition of 'phy_write' was here
static inline int phy_write(struct phy_device *phydev, u32 regnum, u16 val)
^~~~~~~~~
vim +/phy_write +110 drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
f4c8116e294b12 Guido Günther 2019-06-20 109
f4c8116e294b12 Guido Günther 2019-06-20 @110 static int phy_write(struct phy *phy, u32 value, unsigned int reg)
f4c8116e294b12 Guido Günther 2019-06-20 111 {
f4c8116e294b12 Guido Günther 2019-06-20 112 struct mixel_dphy_priv *priv = phy_get_drvdata(phy);
f4c8116e294b12 Guido Günther 2019-06-20 113 int ret;
f4c8116e294b12 Guido Günther 2019-06-20 114
f4c8116e294b12 Guido Günther 2019-06-20 115 ret = regmap_write(priv->regmap, reg, value);
f4c8116e294b12 Guido Günther 2019-06-20 116 if (ret < 0)
f4c8116e294b12 Guido Günther 2019-06-20 117 dev_err(&phy->dev, "Failed to write DPHY reg %d: %d\n", reg,
f4c8116e294b12 Guido Günther 2019-06-20 118 ret);
f4c8116e294b12 Guido Günther 2019-06-20 119 return ret;
f4c8116e294b12 Guido Günther 2019-06-20 120 }
f4c8116e294b12 Guido Günther 2019-06-20 121
:::::: The code at line 110 was first introduced by commit
:::::: f4c8116e294b12c360b724173f4b79f232573fb1 phy: Add driver for mixel mipi dphy found on NXP's i.MX8 SoCs
:::::: TO: Guido Günther <agx at sigxcpu.org>
:::::: CC: Kishon Vijay Abraham I <kishon at ti.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 36397 bytes
Desc: not available
URL: <http://st-md-mailman.stormreply.com/pipermail/linux-stm32/attachments/20200203/d87fcd66/attachment.gz>
More information about the Linux-stm32
mailing list