[Linux-stm32] [PATCH V4 00/22] ARM: dts: stm32: Repair AV96 board

[Marek Vasut]

On 4/21/20 6:04 PM, Alexandre Torgue wrote:
> Hi Marek

Hi,

> On 4/21/20 12:30 PM, Marek Vasut wrote:
>> On 4/1/20 3:22 PM, Marek Vasut wrote:
>>> The AV96 board device tree is completely broken and does not match the
>>> hardware. This series fixes it up.
>>>
>>> Marek Vasut (22):
>>>    ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
>>>    ARM: dts: stm32: Repair ethernet operation on AV96
>>>    ARM: dts: stm32: Add missing ethernet PHY reset on AV96
>>>    ARM: dts: stm32: Add missing ethernet PHY skews on AV96
>>>    ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins
>>>    ARM: dts: stm32: Repair SDMMC1 operation on AV96
>>>    ARM: dts: stm32: Repair PMIC configuration on AV96
>>>    ARM: dts: stm32: Repair PMIC interrupt on AV96
>>>    ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
>>>    ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96
>>>    ARM: dts: stm32: Add QSPI NOR on AV96
>>>    ARM: dts: stm32: Add configuration EEPROM on AV96
>>>    ARM: dts: stm32: Add alternate pinmux for SDMMC3 pins
>>>    ARM: dts: stm32: Enable WiFi on AV96
>>>    ARM: dts: stm32: Add alternate pinmux for USART2 pins
>>>    ARM: dts: stm32: Enable Bluetooth on AV96
>>>    ARM: dts: stm32: Add alternate pinmux for LTDC pins
>>>    ARM: dts: stm32: Add bindings for HDMI video on AV96
>>>    ARM: dts: stm32: Add alternate pinmux for SAI2 pins
>>>    ARM: dts: stm32: Add bindings for audio on AV96
>>>    ARM: dts: stm32: Add bindings for USB on AV96
>>>    ARM: dts: stm32: Rename LEDs to match silkscreen on AV96
>>>
>>>   arch/arm/boot/dts/stm32mp15-pinctrl.dtsi    | 280 +++++++++++++++++
>>>   arch/arm/boot/dts/stm32mp157a-avenger96.dts | 324 ++++++++++++++++++--
>>>   2 files changed, 571 insertions(+), 33 deletions(-)
>>
>> Alex, can you provide some review of this series ? It's been posted for
>> three weeks now.
>>
> 
> Yes, I was waiting for Mani's review first (and I was a bit busy sorry).

It seems most of the patches got that review.

> All patches looks good for me. Maybe I'll squash some pinctrl patches to
> decrease number of patches.

One patch should do one thing and one thing only, no ?

> One remaining questions about patch 7 ("Repair PMIC configuration on
> AV96). I saw a discussion on u-boot thread with pascal P., explaining
> that 800mv is not the minimal voltage acceptable for vddcore. What is
> the status ?

It should likely be set to 1V2, same as 791be94e2878 ("ARM: dts: stm32:
change default minimal buck1 value on stm32mp157") does. I'll add it
into the list of fixes for V5.