[Linux-stm32] [PATCH V2 1/3] mmc: Prepare all code for mmc_regulator_set_vqmmc() returning > 0

[Marek Vasut]

On 4/20/20 10:18 AM, Ulf Hansson wrote:
> On Fri, 17 Apr 2020 at 17:33, Marek Vasut <marex at denx.de> wrote:
>>
>> On 4/17/20 11:30 AM, Ulf Hansson wrote:
>>> On Thu, 16 Apr 2020 at 18:36, Marek Vasut <marex at denx.de> wrote:
>>>>
>>>> Patch all drivers which use mmc_regulator_set_vqmmc() and prepare them for
>>>> the fact that mmc_regulator_set_vqmmc() can return a value > 0, which would
>>>> happen if the signal voltage switch did NOT happen, because the voltage was
>>>> already set correctly.
>>>>
>>>> Signed-off-by: Marek Vasut <marex at denx.de>
>>>> Cc: Alexandre Torgue <alexandre.torgue at st.com>
>>>> Cc: Linus Walleij <linus.walleij at linaro.org>
>>>> Cc: Ludovic Barre <ludovic.barre at st.com>
>>>> Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>
>>>> Cc: Maxime Coquelin <mcoquelin.stm32 at gmail.com>
>>>> Cc: Patrice Chotard <patrice.chotard at st.com>
>>>> Cc: Patrick Delaunay <patrick.delaunay at st.com>
>>>> Cc: Russell King <linux at armlinux.org.uk>
>>>> Cc: Ulf Hansson <ulf.hansson at linaro.org>
>>>> Cc: linux-stm32 at st-md-mailman.stormreply.com
>>>> To: linux-mmc at vger.kernel.org
>>>
>>> Applied for next, thanks!
>>>
>>> I took the liberty to re-work and simplify some of the code, please
>>> have a look at my next branch to make sure I didn't screw something
>>> up.
>>
>> Where is your next branch ?
> 
> It's listed in the MAINTAINERS file.
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git

All right, this one. The adjustments look OK, thanks.

I noticed this one in mtk-sd.c:
/* Apply different pinctrl settings for different signal voltage */
if (ios->signal_voltage == MMC_SIGNAL_VOLTAGE_180)
	pinctrl_select_state(host->pinctrl, host->pins_uhs);
else
	pinctrl_select_state(host->pinctrl, host->pins_default);

I would almost think that the MTK platforms would support 1V2 modes too,
so the above should rather be:

if (ios->signal_voltage == MMC_SIGNAL_VOLTAGE_330)
	pinctrl_select_state(host->pinctrl, host->pins_default);
else
	pinctrl_select_state(host->pinctrl, host->pins_uhs);

But I have no hardware to test, and it's a topic for another patch.