[Linux-stm32] [PATCH] net: stmmac: fix a potential NULL pointer dereference

[Mukesh Ojha]

On 3/23/2019 9:09 AM, Kangjie Lu wrote:
> In case of_device_get_match_data fails, the fix return -EINVAL
> to avoid the NULL pointer dereference.
>
> Signed-off-by: Kangjie Lu <kjlu at umn.edu>
> ---
>   drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
> index 3256e5cbad27..344ead5949b1 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
> @@ -485,6 +485,8 @@ static int dwc_eth_dwmac_remove(struct platform_device *pdev)
>   	int err;
>   
>   	data = of_device_get_match_data(&pdev->dev);
> +	if (!data)
> +		return -EINVAL;

Although, it is false alarm for this driver as of_match_table is not 
NULL, but it would be good to add the check.

Reviewed-by: Mukesh Ojha <mojha at codeaurora.org 
<mailto:mojha at codeaurora.org>>

Thanks.
Mukesh



>   
>   	err = stmmac_dvr_remove(&pdev->dev);
>   	if (err < 0)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://st-md-mailman.stormreply.com/pipermail/linux-stm32/attachments/20190326/7ddb3425/attachment.html>