[Linux-stm32] [PATCH v2] i2c: i2c-stm32f7: fix the get_irq error cases
Wolfram Sang
wsa at the-dreams.de
Fri Jun 14 20:53:22 UTC 2019
Hi Fabrice,
> + return irq_event ? irq_event : -ENODEV;
Maybe -ENOENT instead of -ENODEV? I mean you have a dev_err there, so
the driver core should probably also complain?
You could also shorten the ternary operator to:
return irq_event ? : -E<whatyouprefer>;
However, both are minor nits. If you prefer to keep the patch as is,
fine with me.
Regards,
Wolfram
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://st-md-mailman.stormreply.com/pipermail/linux-stm32/attachments/20190614/8b897870/attachment.sig>
More information about the Linux-stm32
mailing list