[Linux-stm32] [PATCH] dt-bindings: pinctrl: stm32: Fix missing 'clocks' property in examples
Alexandre Torgue
alexandre.torgue at st.com
Thu Jul 18 16:21:48 UTC 2019
Hi Rob
On 7/16/19 11:56 PM, Rob Herring wrote:
> Now that examples are validated against the DT schema, an error with
> required 'clocks' property missing is exposed:
>
> Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \
> pinctrl at 40020000: gpio at 0: 'clocks' is a required property
> Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \
> pinctrl at 50020000: gpio at 1000: 'clocks' is a required property
> Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \
> pinctrl at 50020000: gpio at 2000: 'clocks' is a required property
>
> Add the missing 'clocks' properties to the examples to fix the errors.
>
> Fixes: 2c9239c125f0 ("dt-bindings: pinctrl: Convert stm32 pinctrl bindings to json-schema")
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32 at gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue at st.com>
> Cc: linux-gpio at vger.kernel.org
> Cc: linux-stm32 at st-md-mailman.stormreply.com
> Signed-off-by: Rob Herring <robh at kernel.org>
Acked-by: Alexandre TORGUE <alexandre.torgue at st.com>
Thanks
Alex
> ---
> .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> index 3ac5d2088e49..91d3e78b3395 100644
> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> @@ -197,6 +197,7 @@ required:
> examples:
> - |
> #include <dt-bindings/pinctrl/stm32-pinfunc.h>
> + #include <dt-bindings/mfd/stm32f4-rcc.h>
> //Example 1
> pinctrl at 40020000 {
> #address-cells = <1>;
> @@ -210,6 +211,7 @@ examples:
> #gpio-cells = <2>;
> reg = <0x0 0x400>;
> resets = <&reset_ahb1 0>;
> + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOA)>;
> st,bank-name = "GPIOA";
> };
> };
> @@ -227,6 +229,7 @@ examples:
> #gpio-cells = <2>;
> reg = <0x1000 0x400>;
> resets = <&reset_ahb1 0>;
> + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOB)>;
> st,bank-name = "GPIOB";
> gpio-ranges = <&pinctrl 0 0 16>;
> };
> @@ -236,6 +239,7 @@ examples:
> #gpio-cells = <2>;
> reg = <0x2000 0x400>;
> resets = <&reset_ahb1 0>;
> + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOC)>;
> st,bank-name = "GPIOC";
> ngpios = <5>;
> gpio-ranges = <&pinctrl 0 16 3>,
>
More information about the Linux-stm32
mailing list