[Linux-stm32] [PATCH net] net: stmmac: Re-work the queue selection for TSO packets
David Miller
davem at davemloft.net
Mon Jul 8 19:41:25 UTC 2019
From: Jose Abreu <Jose.Abreu at synopsys.com>
Date: Mon, 8 Jul 2019 14:26:28 +0200
> Ben Hutchings says:
> "This is the wrong place to change the queue mapping.
> stmmac_xmit() is called with a specific TX queue locked,
> and accessing a different TX queue results in a data race
> for all of that queue's state.
>
> I think this commit should be reverted upstream and in all
> stable branches. Instead, the driver should implement the
> ndo_select_queue operation and override the queue mapping there."
>
> Fixes: c5acdbee22a1 ("net: stmmac: Send TSO packets always from Queue 0")
> Suggested-by: Ben Hutchings <ben at decadent.org.uk>
> Signed-off-by: Jose Abreu <joabreu at synopsys.com>
Applied and queued up for -stable.
More information about the Linux-stm32
mailing list