[Linux-stm32] [PATCH] Input: st-keyscan - fix potential zalloc NULL dereference

[Gabriel FERNANDEZ]

Sorry ignore this patch (bad mailing list)

Best Regard

Gabriel

On 2/12/19 4:24 PM, gabriel.fernandez at st.com wrote:
> From: Gabriel Fernandez <gabriel.fernandez at st.com>
>
> This patch fixes the following static checker warning:
>
> drivers/input/keyboard/st-keyscan.c:156 keyscan_probe()
> error: potential zalloc NULL dereference: 'keypad_data->input_dev'
>
> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez at st.com>
> ---
>   drivers/input/keyboard/st-keyscan.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/st-keyscan.c b/drivers/input/keyboard/st-keyscan.c
> index babcfb165e4f..3b85631fde91 100644
> --- a/drivers/input/keyboard/st-keyscan.c
> +++ b/drivers/input/keyboard/st-keyscan.c
> @@ -153,6 +153,8 @@ static int keyscan_probe(struct platform_device *pdev)
>   
>   	input_dev->id.bustype = BUS_HOST;
>   
> +	keypad_data->input_dev = input_dev;
> +
>   	error = keypad_matrix_key_parse_dt(keypad_data);
>   	if (error)
>   		return error;
> @@ -168,8 +170,6 @@ static int keyscan_probe(struct platform_device *pdev)
>   
>   	input_set_drvdata(input_dev, keypad_data);
>   
> -	keypad_data->input_dev = input_dev;
> -
>   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>   	keypad_data->base = devm_ioremap_resource(&pdev->dev, res);
>   	if (IS_ERR(keypad_data->base))