[Linux-stm32] [PATCH v2] net: stmmac: move stmmac_check_ether_addr() to driver probe

Andrew Lunn andrew at lunn.ch
Mon Apr 22 13:30:36 UTC 2019


On Mon, Apr 22, 2019 at 03:15:32PM +0530, Vinod Koul wrote:
> stmmac_check_ether_addr() checks the MAC address and assigns one in
> driver open(). In many cases when we create slave netdevice, the dev
> addr is inherited from master but the master dev addr maybe NULL at
> that time, so move this call to driver probe so that address is
> always valid.
> 
> Signed-off-by: Xiaofei Shen <xiaofeis at codeaurora.org>
> Tested-by: Xiaofei Shen <xiaofeis at codeaurora.org>
> Signed-off-by: Sneh Shah <snehshah at codeaurora.org>
> Signed-off-by: Vinod Koul <vkoul at kernel.org>

Thanks for doing it this way.

Reviewed-by: Andrew Lunn <andrew at lunn.ch>

    Andrew



More information about the Linux-stm32 mailing list