[Linux-stm32] [PATCH] Fix invalid use of sizeof in stm32_sai_add_mclk_provider()
Wen Yang
wen.yang99 at zte.com.cn
Tue Nov 27 12:35:20 UTC 2018
sizeof(mclk) is 4 or 8 as it is the size of a pointer,
but we want to reserve space for the pointed data.
This issue was detected by using the Coccinelle software.
Signed-off-by: Wen Yang <wen.yang99 at zte.com.cn>
CC: Olivier Moysan <olivier.moysan at st.com>
CC: Arnaud Pouliquen <arnaud.pouliquen at st.com>
CC: Liam Girdwood <lgirdwood at gmail.com>
CC: Jaroslav Kysela <perex at perex.cz>
CC: Takashi Iwai <tiwai at suse.com>
CC: Maxime Coquelin <mcoquelin.stm32 at gmail.com>
CC: Alexandre Torgue <alexandre.torgue at st.com>
CC: Julia Lawall <julia.lawall at lip6.fr>
CC: Wen Yang <yellowriver2010 at hotmail.com>
CC: linux-stm32 at st-md-mailman.stormreply.com
CC: linux-kernel at vger.kernel.org
---
sound/soc/stm/stm32_sai_sub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c
index ea05cc91aa05..211589b0b2ef 100644
--- a/sound/soc/stm/stm32_sai_sub.c
+++ b/sound/soc/stm/stm32_sai_sub.c
@@ -390,7 +390,7 @@ static int stm32_sai_add_mclk_provider(struct stm32_sai_sub_data *sai)
char *mclk_name, *p, *s = (char *)pname;
int ret, i = 0;
- mclk = devm_kzalloc(dev, sizeof(mclk), GFP_KERNEL);
+ mclk = devm_kzalloc(dev, sizeof(*mclk), GFP_KERNEL);
if (!mclk)
return -ENOMEM;
--
2.19.1
More information about the Linux-stm32
mailing list