<div dir="ltr"><div dir="ltr">On Fri, Sep 18, 2026 at 7:07 PM Alastair D'Silva <<a href="mailto:alastair@d-silva.org">alastair@d-silva.org</a>> wrote:</div><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, 2026-09-17 at 11:55 -0600, James Hilliard wrote:<br>
> The H616 secondary EMAC supports RMII at 10/100 Mbps and uses a<br>
> separate<br>
> system-control clock register at offset 0x34. Add its binding and a<br>
> sun8i stmmac variant using that register. A distinct compatible<br>
> without<br>
> an older fallback prevents the driver from using EMAC0's clock<br>
> register.<br>
> <br>
> EMAC1 connects internally to the co-packaged AC200 or AC300 EPHY and<br>
> has<br>
> no external PHY pins. Leave PHY initialization to the PHY driver<br>
> instead<br>
> of using the H3 internal-PHY controls. The RMII-only variant does not<br>
> expose the RGMII clock-delay properties.<br>
> <br>
> First move the MAC software reset from probe to the DMA reset<br>
> callback,<br>
> after PHY initialization. This lets the MAC and its MDIO bus remain<br>
> registered when the PHY driver or one of its suppliers is not ready<br>
> yet.<br>
> Keep the separate H3 MDIO-mux reset sequence unchanged.<br>
> <br>
> The AC200/AC300 EPHY driver and package bindings are already in<br>
> net-next. This series separates the H616 EMAC1 MAC driver and binding<br>
> support from the earlier combined series. PWM, MFD and device-tree<br>
> enablement are being handled separately.<br>
> <br>
> Signed-off-by: James Hilliard <<a href="mailto:james.hilliard1@gmail.com" target="_blank">james.hilliard1@gmail.com</a>><br>
> ---<br>
> Changes in v3:<br>
> - Add a prerequisite fix moving the MAC software reset to the DMA<br>
> reset<br>
> callback, after PHY initialization, so delayed module loading and<br>
> deferred PHY probes do not tear down the MAC and its MDIO bus.<br>
> - Preserve the H3 MDIO-mux reset and propagate hardware-reset<br>
> failures<br>
> through the normal stmmac hardware-setup error path.<br>
> - Add Alastair D'Silva to Cc and rebase onto current net-next.<br>
> - Link to v2: <a href="https://patch.msgid.link/20260915-submit-h616-emac1-v1-" rel="noreferrer" target="_blank">https://patch.msgid.link/20260915-submit-h616-emac1-v1-</a><br>
> <a href="mailto:v2-0-322b32e40eb9@gmail.com" target="_blank">v2-0-322b32e40eb9@gmail.com</a><br>
> <br>
> Changes in v2:<br>
> - Drop EMAC1 TX/RX clock-delay property support and keep the existing<br>
> RGMII-only delay descriptions unchanged, as requested by Maxime<br>
> Ripard.<br>
> - Clarify that EMAC1 connects internally to a co-packaged PHY, not an<br>
> external PHY or the H3-style internal-PHY controls.<br>
> - Rebase onto current net-next.<br>
> - Link to v1: <a href="https://patch.msgid.link/20260915-submit-h616-emac1-v1-" rel="noreferrer" target="_blank">https://patch.msgid.link/20260915-submit-h616-emac1-v1-</a><br>
> <a href="mailto:v1-0-195de0bb1f8a@gmail.com" target="_blank">v1-0-195de0bb1f8a@gmail.com</a><br>
> <br>
> ---<br>
> James Hilliard (3):<br>
> net: stmmac: sun8i: reset the MAC after PHY initialization<br>
> dt-bindings: net: allwinner: add H616 EMAC1<br>
> net: stmmac: sun8i: add support for Allwinner H616 EMAC1<br>
> <br>
> .../bindings/net/allwinner,sun8i-a83t-emac.yaml | 13 +++++<br>
> .../devicetree/bindings/net/snps,dwmac.yaml | 2 +<br>
> drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 66<br>
> +++++++++++++---------<br>
> 3 files changed, 55 insertions(+), 26 deletions(-)<br>
> ---<br>
> base-commit: 26ee8cd69d46a14b37ba5e512084fe80d730127a<br>
> change-id: 20260914-submit-h616-emac1-v1-143703842abb<br>
> <br>
> Best regards,<br>
> -- <br>
> James Hilliard <<a href="mailto:james.hilliard1@gmail.com" target="_blank">james.hilliard1@gmail.com</a>><br>
> <br>
<br>
Tested-by: Alastair D'Silva <<a href="mailto:alastair@d-silva.org" target="_blank">alastair@d-silva.org</a>><br>
Reviewed-by: Alastair D'Silva <<a href="mailto:alastair@d-silva.org" target="_blank">alastair@d-silva.org</a>><br>
<br>
As a follow-up (non blocking), I would add the LED control registers I<br>
mentioned at the bottom of my test results. <br></blockquote><div><br></div><div>I have plenty of features to work on afterwards including LED related</div><div>configs, want to just get basic connectivity working to start with to make</div><div>everything easier to review.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
-- <br>
Alastair D'Silva<br>
</blockquote></div></div>