<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Junlin<br>
</p>
<p><br>
</p>
<p>Thank you for the patch!</p>
<p><br>
</p>
<p>Fabien<br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:AM9PR10MB4119423F89C44A1F840A32809A889@AM9PR10MB4119.EURPRD10.PROD.OUTLOOK.COM">
<div class="moz-text-plain" wrap="true" style="font-family:
-moz-fixed; font-size: 12px;" lang="x-western">
<pre class="moz-quote-pre" wrap="">
From: Junlin Yang <a class="moz-txt-link-rfc2396E" href="mailto:yangjunlin@yulong.com"><yangjunlin@yulong.com></a>
Fix OF node leaks by calling of_node_put in for_each_available_child_of_node when the cycle returns.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
Signed-off-by: Junlin Yang <a class="moz-txt-link-rfc2396E" href="mailto:yangjunlin@yulong.com"><yangjunlin@yulong.com></a></pre>
</div>
</blockquote>
<p>Acked-by: Fabien Dessenne <a class="moz-txt-link-rfc2396E" href="mailto:fabien.dessenne@foss.st.com"><fabien.dessenne@foss.st.com></a><br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:AM9PR10MB4119423F89C44A1F840A32809A889@AM9PR10MB4119.EURPRD10.PROD.OUTLOOK.COM">
<div class="moz-text-plain" wrap="true" style="font-family:
-moz-fixed; font-size: 12px;" lang="x-western">
<pre class="moz-quote-pre" wrap="">
---
drivers/pinctrl/stm32/pinctrl-stm32.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
index 7d9bded..da72e3e 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
@@ -1542,8 +1542,10 @@ int stm32_pctl_probe(struct platform_device *pdev)
if (of_property_read_bool(child, "gpio-controller")) {
bank->rstc = of_reset_control_get_exclusive(child,
NULL);
- if (PTR_ERR(bank->rstc) == -EPROBE_DEFER)
+ if (PTR_ERR(bank->rstc) == -EPROBE_DEFER) {
+ of_node_put(child);
return -EPROBE_DEFER;
+ }
bank->clk = of_clk_get_by_name(child, NULL);
if (IS_ERR(bank->clk)) {
@@ -1551,6 +1553,7 @@ int stm32_pctl_probe(struct platform_device *pdev)
dev_err(dev,
"failed to get clk (%ld)\n",
PTR_ERR(bank->clk));
+ of_node_put(child);
return PTR_ERR(bank->clk);
}
i++;
--
1.9.1
</pre>
</div>
</blockquote>
</body>
</html>