<div dir="ltr"><div>Hi Philippe Schenker,</div><div><br></div><div>thanks for your quick reply. i check the stmpe code, it's not use id, block, irq-trigger anymore.</div><div>i will remove these three configuration in dts, and submit again. </div><div><br></div><div>thanks.</div><div><br></div><div>regards.</div><div><div><br></div>dillon, </div><div> <br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Philippe Schenker <<a href="mailto:philippe.schenker@toradex.com">philippe.schenker@toradex.com</a>> 于2020年5月7日周四 下午4:32写道：<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, 2020-05-07 at 15:47 +0800, <a href="mailto:dillon.minfei@gmail.com" target="_blank">dillon.minfei@gmail.com</a> wrote:<br>
> From: dillon min <<a href="mailto:dillon.minfei@gmail.com" target="_blank">dillon.minfei@gmail.com</a>><br>
> <br>
> Enable the stmpe811 touch screen on stm32429-disco board.<br>
> <br>
> Signed-off-by: dillon min <<a href="mailto:dillon.minfei@gmail.com" target="_blank">dillon.minfei@gmail.com</a>><br>
> ---<br>
>  arch/arm/boot/dts/stm32f429-disco.dts | 50<br>
> +++++++++++++++++++++++++++++++++++<br>
>  1 file changed, 50 insertions(+)<br>
> <br>
> diff --git a/arch/arm/boot/dts/stm32f429-disco.dts<br>
> b/arch/arm/boot/dts/stm32f429-disco.dts<br>
> index 30c0f67..f9f21c8 100644<br>
> --- a/arch/arm/boot/dts/stm32f429-disco.dts<br>
> +++ b/arch/arm/boot/dts/stm32f429-disco.dts<br>
> @@ -49,6 +49,8 @@<br>
>  #include "stm32f429.dtsi"<br>
>  #include "stm32f429-pinctrl.dtsi"<br>
>  #include <dt-bindings/input/input.h><br>
> +#include <dt-bindings/interrupt-controller/irq.h><br>
> +#include <dt-bindings/gpio/gpio.h><br>
>  <br>
>  / {<br>
>       model = "STMicroelectronics STM32F429i-DISCO board";<br>
> @@ -127,3 +129,51 @@<br>
>       pinctrl-names = "default";<br>
>       status = "okay";<br>
>  };<br>
> +<br>
> +&i2c3 {<br>
> +     pinctrl-names = "default";<br>
> +     pinctrl-0 = <&i2c3_pins>;<br>
> +     clock-frequency = <100000>;<br>
> +     status = "okay";<br>
> +<br>
> +     stmpe811@41 {<br>
> +             compatible = "st,stmpe811";<br>
> +             reg = <0x41>;<br>
> +             interrupts = <15 IRQ_TYPE_EDGE_FALLING>;<br>
> +             interrupt-parent = <&gpioa>;<br>
> +             id = <0>;<br>
> +             blocks = <0x5>;<br>
> +             irq-trigger = <0x1>;<br>
<br>
I can't find id, blocks and irq-trigger in the binding. What are they<br>
for?<br>
<br>
Philippe<br>
<br>
> +             /* 3.25 MHz ADC clock speed */<br>
> +             st,adc-freq = <1>;<br>
> +             /* 12-bit ADC */<br>
> +             st,mod-12b = <1>;<br>
> +             /* internal ADC reference */<br>
> +             st,ref-sel = <0>;<br>
> +             /* ADC converstion time: 80 clocks */<br>
> +             st,sample-time = <4>;<br>
> +<br>
> +             stmpe_touchscreen {<br>
> +                     compatible = "st,stmpe-ts";<br>
> +                     /* 8 sample average control */<br>
> +                     st,ave-ctrl = <3>;<br>
> +                     /* 7 length fractional part in z */<br>
> +                     st,fraction-z = <7>;<br>
> +                     /*<br>
> +                      * 50 mA typical 80 mA max touchscreen drivers<br>
> +                      * current limit value<br>
> +                      */<br>
> +                     st,i-drive = <1>;<br>
> +                     /* 1 ms panel driver settling time */<br>
> +                     st,settling = <3>;<br>
> +                     /* 5 ms touch detect interrupt delay */<br>
> +                     st,touch-det-delay = <5>;<br>
> +             };<br>
> +<br>
> +             stmpe_adc {<br>
> +                     compatible = "st,stmpe-adc";<br>
> +                     /* forbid to use ADC channels 3-0 (touch) */<br>
> +                     st,norequest-mask = <0x0F>;<br>
> +             };<br>
> +     };<br>
> +};<br>
</blockquote></div></div></div>