hi, alexandre torgue<div><br></div><div>so, if i add "---" below</div><div> Signed-off-by: dillon min <<a href="mailto:dillon.minfei@gmail.com" target="_blank">dillon.minfei@gmail.com</a>></div><div> in git commit process, with changes log after that. the log will not show in commit messages, but will exist in git patchs, just showing for reviewers ?</div><div><br></div><div>i will try this tomorrow, resubmit it.</div><div><br></div><div>thanks for your help.</div><div><br></div><div>best regards</div><div><br></div><div>dillon<br><br>在 2020年5月7日星期四，Alexandre Torgue <<a href="mailto:alexandre.torgue@st.com">alexandre.torgue@st.com</a>> 写道：<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Dillon<br>
<br>
On 5/7/20 1:15 PM, <a href="mailto:dillon.minfei@gmail.com" target="_blank">dillon.minfei@gmail.com</a> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: dillon min <<a href="mailto:dillon.minfei@gmail.com" target="_blank">dillon.minfei@gmail.com</a>><br>
<br>
Enable the stmpe811 touch screen on stm32429-disco board.<br>
<br>
Signed-off-by: dillon min <<a href="mailto:dillon.minfei@gmail.com" target="_blank">dillon.minfei@gmail.com</a>><br>
<br>
[PATCH 3/4]: ARM: dts: stm32: enable stmpe811 on stm32429-disco<br>
<br>
V2:<br>
patch 3: remove unused id, blocks, irq-trigger<br>
<br>
V1:<br>
patch 4: fix read touch screen xyz timeout bug<br>
patch 3: enable stmpe_touchscreen on stm32f429-disco board<br>
patch 2: add i2c3 pin mux for stm32f4<br>
patch 1: add i2c3 controller interface for stm32f4<br>
</blockquote>
<br>
Good idea to add changes log for this patch. But this log has to be placed after "---" below. This log has not to appear in your commit message. Furthermore, you should only add changes for this patch without talking about other patches .<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Signed-off-by: dillon min <<a href="mailto:dillon.minfei@gmail.com" target="_blank">dillon.minfei@gmail.com</a>><br>
---<br>
</blockquote>
<br>
Add patch change log here.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
arch/arm/boot/dts/stm32f429-di<wbr>sco.dts | 47 ++++++++++++++++++++++++++++++<wbr>+++++<br>
1 file changed, 47 insertions(+)<br>
<br>
diff --git a/arch/arm/boot/dts/stm32f429-<wbr>disco.dts b/arch/arm/boot/dts/stm32f429-<wbr>disco.dts<br>
index 30c0f67..fad1ec1 100644<br>
--- a/arch/arm/boot/dts/stm32f429-<wbr>disco.dts<br>
+++ b/arch/arm/boot/dts/stm32f429-<wbr>disco.dts<br>
@@ -49,6 +49,8 @@<br>
#include "stm32f429.dtsi"<br>
#include "stm32f429-pinctrl.dtsi"<br>
#include <dt-bindings/input/input.h><br>
+#include <dt-bindings/interrupt-control<wbr>ler/irq.h><br>
+#include <dt-bindings/gpio/gpio.h><br>
/ {<br>
model = "STMicroelectronics STM32F429i-DISCO board";<br>
@@ -127,3 +129,48 @@<br>
pinctrl-names = "default";<br>
status = "okay";<br>
};<br>
+<br>
+&i2c3 {<br>
+ pinctrl-names = "default";<br>
+ pinctrl-0 = <&i2c3_pins>;<br>
+ clock-frequency = <100000>;<br>
+ status = "okay";<br>
+<br>
+ stmpe811@41 {<br>
+ compatible = "st,stmpe811";<br>
+ reg = <0x41>;<br>
+ interrupts = <15 IRQ_TYPE_EDGE_FALLING>;<br>
+ interrupt-parent = <&gpioa>;<br>
+ /* 3.25 MHz ADC clock speed */<br>
+ st,adc-freq = <1>;<br>
+ /* 12-bit ADC */<br>
+ st,mod-12b = <1>;<br>
+ /* internal ADC reference */<br>
+ st,ref-sel = <0>;<br>
+ /* ADC converstion time: 80 clocks */<br>
+ st,sample-time = <4>;<br>
+<br>
+ stmpe_touchscreen {<br>
+ compatible = "st,stmpe-ts";<br>
+ /* 8 sample average control */<br>
+ st,ave-ctrl = <3>;<br>
+ /* 7 length fractional part in z */<br>
+ st,fraction-z = <7>;<br>
+ /*<br>
+ * 50 mA typical 80 mA max touchscreen drivers<br>
+ * current limit value<br>
+ */<br>
+ st,i-drive = <1>;<br>
+ /* 1 ms panel driver settling time */<br>
+ st,settling = <3>;<br>
+ /* 5 ms touch detect interrupt delay */<br>
+ st,touch-det-delay = <5>;<br>
+ };<br>
+<br>
+ stmpe_adc {<br>
+ compatible = "st,stmpe-adc";<br>
+ /* forbid to use ADC channels 3-0 (touch) */<br>
+ st,norequest-mask = <0x0F>;<br>
+ };<br>
+ };<br>
+};<br>
<br>
</blockquote>
<br>
______________________________<wbr>_________________<br>
linux-arm-kernel mailing list<br>
<a href="mailto:linux-arm-kernel@lists.infradead.org" target="_blank">linux-arm-kernel@lists.infrade<wbr>ad.org</a><br>
<a href="http://lists.infradead.org/mailman/listinfo/linux-arm-kernel" target="_blank">http://lists.infradead.org/mai<wbr>lman/listinfo/linux-arm-kernel</a><br>
</blockquote></div>